Lower TypeScript keynote bench threshold#5333
Open
clockwork-labs-bot wants to merge 1 commit into
Open
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler,
jdetter and
joshua-spacetime
as code owners
joshua-spacetime
requested changes
Jun 15, 2026
joshua-spacetime
left a comment
joshua-spacetime
left a comment
Contributor
There was a problem hiding this comment.
We should figure out why it regressed. Not lower the threshold. It was running over 300K previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Lowers the TypeScript keynote benchmark throughput threshold from 275K TPS to 260K TPS.
This gives the benchmark enough margin for the recent observed run at 270,192 TPS while keeping the perf gate close to the current expected range.
Fixes #5332.
API and ABI breaking changes
None.
Expected complexity level and risk
Testing
cargo fmt --allcargo check -p cicargo ci self-docs --checkgit diff --check